feat(performance): Update performance score calculation to checking profiles after the first match #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjq
approved these changes
Jul 10, 2024
jjbayer
approved these changes
Jul 11, 2024
| @@ -946,6 +946,7 @@ pub fn normalize_performance_score( | |||
| ); | |||
| } | |||
| } | |||
| break; // Stop after the first matching profile. | |||
There was a problem hiding this comment.
This loop has become quite large and contains a few continue and break statements now, which seems error-prone. I think we could refactor this into a two-step approach that first finds a profile that matches all conditions, then runs calculations with that profile.
let Some(measurements) = event.measurements.value_mut() { else return };
let Some(profile) = performance_score.profiles.find(|profile| {
profile.condition.is_some_and(|condition| condition.matches(event))
&& components_match_measurement(&profile.score_components, &measurements)
) { else return };
// ...There was a problem hiding this comment.
👍 sounds good, i'll follow this up with a refactor pr!
edwardgou-sentry
deleted the
egou/feat/performance-score-stop-after-first-match
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the performance score calculation to break after find a profile with a matching condition. This prevents any subsequent matching profiles from overwriting calculated performance scores. This is needed because we will be adding a
defaultfallback profile with a condition matching on any to the bottom of the profiles list.#skip-changelog